-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flow for signac 1.8.0 #693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-butler
requested review from
kidrahahjo and
lyrivera
and removed request for
a team
November 29, 2022 16:42
b-butler
added a commit
that referenced
this pull request
Nov 29, 2022
b-butler
force-pushed
the
fix/signac-integration
branch
from
November 29, 2022 16:47
06f98db
to
de3f222
Compare
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
- Coverage 80.29% 80.19% -0.10%
==========================================
Files 30 30
Lines 3136 3136
Branches 675 675
==========================================
- Hits 2518 2515 -3
- Misses 485 487 +2
- Partials 133 134 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bdice
approved these changes
Nov 30, 2022
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title. Also updates flow to require at least signac 1.8.0. There will be more breaking changes for 2.0, but we should wait for 2.0 to be released to do that. This also deprecated the usage of
alias
inflow init
while also rendering it effete.Motivation and Context
To make tests pass and remove deprecation warnings.
Checklist: