Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow for signac 1.8.0 #693

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Update flow for signac 1.8.0 #693

merged 7 commits into from
Nov 30, 2022

Conversation

b-butler
Copy link
Member

@b-butler b-butler commented Nov 29, 2022

Description

See title. Also updates flow to require at least signac 1.8.0. There will be more breaking changes for 2.0, but we should wait for 2.0 to be released to do that. This also deprecated the usage of alias in flow init while also rendering it effete.

Motivation and Context

To make tests pass and remove deprecation warnings.

Checklist:

@b-butler b-butler requested review from a team as code owners November 29, 2022 16:42
@b-butler b-butler requested review from kidrahahjo and lyrivera and removed request for a team November 29, 2022 16:42
b-butler added a commit that referenced this pull request Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #693 (190d978) into master (95f2af6) will decrease coverage by 0.09%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   80.29%   80.19%   -0.10%     
==========================================
  Files          30       30              
  Lines        3136     3136              
  Branches      675      675              
==========================================
- Hits         2518     2515       -3     
- Misses        485      487       +2     
- Partials      133      134       +1     
Impacted Files Coverage Δ
flow/template.py 80.00% <ø> (-6.67%) ⬇️
flow/__main__.py 82.35% <66.66%> (+0.21%) ⬆️
flow/project.py 82.66% <66.66%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

flow/__main__.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants