Deprecate FlowGroupEntry.with_directives #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also deprecates FlowGroupEntry.with_directives.
b-butler
requested review from
csadorf and
syjlee
and removed request for
a team
csadorf
requested changes
Dec 1, 2022
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
bdice
approved these changes
Dec 4, 2022
bdice
reviewed
Dec 4, 2022
| @@ -1703,7 +1703,9 @@ class A(FlowProject): | |||
| def foo_operation(job): | |||
| pass | |||
|
|
|||
| @pytest.mark.filterwarnings("ignore:*with_directives*:FutureWarning") | |||
| @pytest.mark.filterwarnings( | |||
| "ignore:.*with_directives has been deprecated.*:FutureWarning" | |||
There was a problem hiding this comment.
@b-butler The message is a regex, not a glob. Previously it started with *, which means "repeat previous character". This caused pytest to crash because no previous character was defined for a string starting with *.
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
- Coverage 80.27% 80.27% -0.01%
==========================================
Files 30 30
Lines 3143 3153 +10
Branches 767 770 +3
==========================================
+ Hits 2523 2531 +8
- Misses 485 486 +1
- Partials 135 136 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bdice
reviewed
Dec 4, 2022
|
@csadorf I'd like to let you approve this before merging since you requested changes. I think it's ready to go once you approve. |
bdice
reviewed
Dec 4, 2022
csadorf
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
directiveskeyword-only argument toFlowGroupEntry.__call__.Motivation and Context
Mimics the changes to
FlowGroup.operation.Checklist: