Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.11 support #697

Merged
merged 8 commits into from
Dec 4, 2022
Merged

Add python 3.11 support #697

merged 8 commits into from
Dec 4, 2022

Conversation

b-butler
Copy link
Member

@b-butler b-butler commented Dec 1, 2022

Description

Add Python 3.11 to CI.

Motivation and Context

Python 3.11 go fast 🐎 .

Checklist:

@b-butler b-butler requested review from a team as code owners December 1, 2022 22:05
@b-butler b-butler requested review from tcmoore3 and pepak13 and removed request for a team December 1, 2022 22:05
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
b-butler and others added 5 commits December 2, 2022 10:30
Forgot to change the python version itself.

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Make a __str__ method for `JobStatus` which reverts back to printing out
the enum member's name.
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #697 (79c2e93) into master (6834810) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 79c2e93 differs from pull request most recent head 7fb55cd. Consider uploading reports for the commit 7fb55cd to get more accurate results

@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   80.19%   80.21%   +0.01%     
==========================================
  Files          30       30              
  Lines        3136     3138       +2     
  Branches      675      764      +89     
==========================================
+ Hits         2515     2517       +2     
  Misses        487      487              
  Partials      134      134              
Impacted Files Coverage Δ
flow/scheduling/base.py 78.12% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b-butler b-butler requested a review from bdice December 2, 2022 20:02
@bdice
Copy link
Member

bdice commented Dec 4, 2022

@b-butler Are you dropping the 3.8 CI configuration with "newest" dependencies on purpose? It wasn't listed in the description. I would prefer to keep it. It is still a required check. (We'll need to drop the required checks for testing against signac 1.5 and signac 1.6, I will take care of that now.)

@bdice
Copy link
Member

bdice commented Dec 4, 2022

For now, I might just add back the 3.8 "newest" configuration and merge this. It looks good otherwise. We can debate the extents of our CI matrix separately, since we want to move this repo to GitHub Actions anyway.

@bdice bdice enabled auto-merge (squash) December 4, 2022 17:27
@bdice bdice merged commit c21b91f into master Dec 4, 2022
@bdice bdice deleted the add-python-3.11-support branch December 4, 2022 17:31
@bdice bdice added this to the v0.23.0 milestone Dec 4, 2022
@b-butler
Copy link
Member Author

b-butler commented Dec 5, 2022

@bdice My thoughts were that testing latest versions of dependencies on 3.9 up is sufficient (it does require trusting the Python requirements are right for our dependencies) along with our oldest allowable configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants