-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.11 support #697
Conversation
Forgot to change the python version itself. Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Make a __str__ method for `JobStatus` which reverts back to printing out the enum member's name.
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 80.19% 80.21% +0.01%
==========================================
Files 30 30
Lines 3136 3138 +2
Branches 675 764 +89
==========================================
+ Hits 2515 2517 +2
Misses 487 487
Partials 134 134
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@b-butler Are you dropping the 3.8 CI configuration with "newest" dependencies on purpose? It wasn't listed in the description. I would prefer to keep it. It is still a required check. (We'll need to drop the required checks for testing against signac 1.5 and signac 1.6, I will take care of that now.) |
For now, I might just add back the 3.8 "newest" configuration and merge this. It looks good otherwise. We can debate the extents of our CI matrix separately, since we want to move this repo to GitHub Actions anyway. |
@bdice My thoughts were that testing latest versions of dependencies on 3.9 up is sufficient (it does require trusting the Python requirements are right for our dependencies) along with our oldest allowable configuration. |
Description
Add Python 3.11 to CI.
Motivation and Context
Python 3.11 go fast 🐎 .
Checklist: