Add GitHub Actions. #698
Add GitHub Actions. #698
Conversation
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
+ Coverage 68.42% 68.57% +0.14%
==========================================
Files 41 41
Lines 4162 4162
Branches 1025 1025
==========================================
+ Hits 2848 2854 +6
+ Misses 1103 1097 -6
Partials 211 211
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bdice
requested review from
mikemhenry and
shihkual
and removed request for
a team
| on: | ||
| push: | ||
| branches: | ||
| - 'release/*.*.*' |
There was a problem hiding this comment.
publish-packages.yml is not tested in this PR because it does not match this branch name. You could remove this condition temporarily to test it, or remove it permanently. GitHub Actions provides many runners, so the additional testing time is not an issue.
There was a problem hiding this comment.
This script matches the testing workflows on signac-dashboard, which were copied from signac. I think I trust this workflow from those two repos, so I was going to leave it “untested” until 0.23.0 release time. I don’t think we want to publish test packages on every branch/commit.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest] |
There was a problem hiding this comment.
Windows is not fully supported by signac-flow. We have a number of features like command line operations and “with job” that inject UNIX-specific things like trap commands. About 80% of our test suite passes on Windows, if I recall correctly, but tests of job submission and a few other categories fail.
There was a problem hiding this comment.
This is an area for improvement — we should mark some tests as skip on Windows, and/or block those features with explicit errors on Windows. I don’t think we have received many complaints about support, but I know we have some users of the package’s partial functionality on Windows so I don’t want to explicitly disallow installation of the package on Windows as an unsupported platform.
There was a problem hiding this comment.
I agree that we can improve here, but I think we are okay to merge this without it.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest] |
There was a problem hiding this comment.
I agree that we can improve here, but I think we are okay to merge this without it.
| - name: Test with pytest | ||
| run: | | ||
| pytest --cov=flow --cov-config=setup.cfg --cov-report=xml tests/ -v | ||
| - uses: codecov/codecov-action@v3 |
There was a problem hiding this comment.
Do we want to have CI fail if codecov report upload fails? Sometimes it can be flaky, not sure if we have ran into that with this repo
There was a problem hiding this comment.
I'm not going to worry about this. It's probably fine.
Description
Migrates signac-flow's CI to use GitHub Actions.
This PR drops coverage for a few things that I think are non-essential:
pip install signac signac-flowandconda install signac signac-flowsignac(which is currently disabled because it's broken until we release 2.0)release/.*branches.If another contributor wishes to add these to GitHub Actions, that would be fine.
Before merging, a repo administrator will need to update the CI checks used for branch protections.
Checklist: