Fix operation group status #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-butler
requested review from
bdice and
Tobias-Dwyer
and removed request for
a team
|
@bdice yeah. I will fix with a rebase. 🙃 |
- _gather_selected_flow_groups: which selects groups regardless of executability - _gather_executable_flow_groups: which defaults to singleton groups and only allows executable outputs or errors.
b-butler
force-pushed
the
fix/operation-group-status
branch
from
f7a9ba9
to
a5d3313
Compare
|
@bdice fixed. Sorry about that. |
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
==========================================
- Coverage 69.15% 69.11% -0.04%
==========================================
Files 44 44
Lines 4295 4297 +2
Branches 1047 950 -97
==========================================
Hits 2970 2970
- Misses 1114 1115 +1
- Partials 211 212 +1
|
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
|
I can confirm this fixes the main issue described in #773. However, just to make it clear, the related bug mentioned in #773. I think this is simple and related enough to just fix it here. I would gladly do it, but I don't have permission to add commits to this PR... It would just be a simple change: just change this line to |
For operations in multi-operation groups, the shared status dictionary would get overwritten in status printing specifically the display name. This results in only the last being printed.
|
As far as I can tell, this now completely fixes #773 . Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct the selection of groups in
statusfunctions and splits_gather_flow_groupsinto 2 functions with clearer names.Motivation and Context
Resolves: #773
Checklist: