Deprecate current directives syntax. #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-butler
requested review from
bdice and
jennyfothergill
and removed request for
a team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 69.54% 69.53% -0.02%
==========================================
Files 48 48
Lines 4417 4422 +5
Branches 1069 1071 +2
==========================================
+ Hits 3072 3075 +3
- Misses 1138 1139 +1
- Partials 207 208 +1 ☔ View full report in Codecov by Sentry. |
cbkerr
reviewed
Jan 2, 2024
flow/project.py
Outdated
| if directives is not None: | ||
| warnings.warn( | ||
| "The current directives are deprecated as of flow 0.27. When updating flow " | ||
| "please look at the documentation for the new style.", |
There was a problem hiding this comment.
It would be nice to have a link to where this documentation will be or at least keep it updated as this changes
bdice
changed the title
bdice
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds deprecation warnings to the entry points for directives.
Motivation and Context
In order to make the new directives style possible, we need to remove the current way we handle directives (see #785).
Checklist: