Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SLURM scripts on SDSC Expanse. #810

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Fix SLURM scripts on SDSC Expanse. #810

merged 3 commits into from
Feb 5, 2024

Conversation

joaander
Copy link
Member

@joaander joaander commented Feb 5, 2024

Description

Correct variable names in expanse jinja template.

Motivation and Context

Generate correctly formatted slurm scripts on expanse.

Checklist:

@joaander joaander requested review from a team as code owners February 5, 2024 15:19
@joaander joaander requested review from kidrahahjo and iblanco11981870 and removed request for a team February 5, 2024 15:19
@joaander joaander changed the title Fix/expanse rebased Fix SLURM scripts on SDSC Expanse. Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba2a3ae) 69.25% compared to head (900f141) 69.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   69.25%   69.27%   +0.02%     
==========================================
  Files          48       48              
  Lines        4397     4397              
  Branches     1065     1065              
==========================================
+ Hits         3045     3046       +1     
+ Misses       1143     1142       -1     
  Partials      209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cbkerr cbkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cbkerr cbkerr merged commit da6fc8f into main Feb 5, 2024
11 checks passed
@cbkerr cbkerr deleted the fix/expanse-rebased branch February 5, 2024 16:12
@joaander
Copy link
Member Author

joaander commented Feb 5, 2024

Thanks to @b-butler for the first pass at this fix. I rebased his changes off the latest main branch.

@cbkerr cbkerr added this to the 0.28.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants