-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation and usage of signac.testing #709
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Let's make a decision on what to do with this. If we want to leverage |
While I agree with the premise of this issue that standard methods for initializing test data could be helpful, I'd vote to remove Line 2450 in 7f2297d
Moreover, it's supporting us keeping unnecessary baggage in signac-flow. The function And a corresponding project template (we really don't need project templates in flow...): |
That was basically my original position: I agree that this is a nice idea, but in practice none of us use it so it might not be the best starting point. @csadorf do you still think this is worth doing? An alternative would be to remove this for 2.0, but the next time we do any refactoring of tests we make an effort to extract this type of logic from tests into a single reusable function/fixture that we can expose publicly afterwards. |
I am a bit surprised that this is not used in practice, considering that similar components exist in many other frameworks, but if that's the reality, I see no reason to keep it. |
If we are tired of making changes for 2.0, I have no problem with keeping it and leaving the status quo. This can be cleaned up and expanded OR removed in a future release. I don’t think the change is essential for 2.0. |
Discussed today at the developer meeting: the |
Feature description
It would be helpful to have some standard methods for populating a signac Project, both for signac's own tests and for developer prototyping. Currently
signac.testing
contains a helpful function for creating jobs in a project, but this functionality is largely untested, it is unused even in our own tests, and there's no visible documentation for it.Proposed solution
We should improve the documentation and visibility of the existing functionality of
signac.testing
, and perhaps we should flesh it out in order to support broader usage based on the needs of our existing tests.Additional context
https://github.com/glotzerlab/signac/pull/685/files/5f61c44ce0ac653633baaa6e1d20138e9ccc899b#r813880252
The text was updated successfully, but these errors were encountered: