Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing module. #691

Merged
merged 4 commits into from
Nov 26, 2022
Merged

Remove testing module. #691

merged 4 commits into from
Nov 26, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 26, 2022

Description

Remove the testing module.

Motivation and Context

See glotzerlab/signac#709

Checklist:

@vyasr vyasr self-assigned this Nov 26, 2022
@vyasr vyasr requested review from a team as code owners November 26, 2022 15:43
@vyasr vyasr requested review from bdice and klywang and removed request for a team November 26, 2022 15:43
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #691 (373a989) into master (3a2177a) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 373a989 differs from pull request most recent head ca75b39. Consider uploading reports for the commit ca75b39 to get more accurate results

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   80.21%   80.29%   +0.07%     
==========================================
  Files          31       30       -1     
  Lines        3144     3136       -8     
  Branches      675      675              
==========================================
- Hits         2522     2518       -4     
+ Misses        489      485       -4     
  Partials      133      133              

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix to the changelog, otherwise LGTM.

changelog.txt Outdated Show resolved Hide resolved
flow/testing.py Show resolved Hide resolved
@vyasr vyasr enabled auto-merge (squash) November 26, 2022 18:56
@vyasr vyasr merged commit 95f2af6 into master Nov 26, 2022
@vyasr vyasr deleted the refactor/remove_testing branch November 26, 2022 19:04
iblanco11981870 pushed a commit that referenced this pull request Nov 29, 2022
* Remove testing module.

* Update changelog.

* Fix wording.

* Fix typo.
@bdice bdice added this to the v0.23.0 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants