Add proposed 'window/progress' notification #103
Conversation
src/notification.rs
Outdated
| @@ -59,6 +59,10 @@ macro_rules! lsp_notification { | |||
| ("workspace/didChangeWorkspaceFolders") => { | |||
| $crate::notification::DidChangeWorkspaceFolders | |||
| }; | |||
| // Proposed | |||
| // ("window/progress") => { | |||
There was a problem hiding this comment.
Initially I wanted to warn the user if they're trying to use a feature that's proposed but since the macro has to return specifically a type, I wasn't sure what to return here, so I just commented it out
There was a problem hiding this comment.
Should be fine to just return the type as normal, if proposed is not enabled then it will just be a compile error. (Add a comment on it so people can at least read to source to see why it does not work).
src/notification.rs
Outdated
| @@ -59,6 +59,10 @@ macro_rules! lsp_notification { | |||
| ("workspace/didChangeWorkspaceFolders") => { | |||
| $crate::notification::DidChangeWorkspaceFolders | |||
| }; | |||
| // Proposed | |||
| // ("window/progress") => { | |||
There was a problem hiding this comment.
Should be fine to just return the type as normal, if proposed is not enabled then it will just be a compile error. (Add a comment on it so people can at least read to source to see why it does not work).
|
What is left after microsoft/vscode-languageserver-node#261 to make it properly part of the spec? |
Xanewok
force-pushed
the
window-progress
branch
from
1c0b4f2
to
af822f7
Compare
|
Done, addressed the feedback. While modifying .travis.yml it made sense to test also
That's... actually a good question. So the PR is proposed and a reference implementation is provided as per their recommendation. I imagine the proposed features will make it in next LSP version (3.15?) so that the users can start using it. |
Xanewok
force-pushed
the
window-progress
branch
from
af822f7
to
3baaed8
Compare
Xanewok
force-pushed
the
window-progress
branch
from
3baaed8
to
565f1c7
Compare
|
The checks are all green now. I also added stable support (since we're not using any nightly features) - is that okay? |
|
Released as 0.57. |
|
Thanks! 🎉 |
|
For better or worse, this was further split into 4 different message literals - microsoft/language-server-protocol#70 (comment) |
|
Whelp, I guess this still works until it gets properly stabilized though? |
|
Yeah, it does; this was a proposed extension by Facebook et al. and couple of servers adopted this |
Closes #43.
Sorry, I'm too itchy to not open it - the original proposed PR has been opened 1.5 years ago so it's about time 😀
This adds
proposedfeature which enables proposed LSP extensions.RLS PR that's working and which only reexports the types - Xanewok/rls@68da767