Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dummy method #1150

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Add dummy method #1150

merged 2 commits into from
Jun 7, 2022

Conversation

jperedadnr
Copy link
Contributor

Issue

Fixes #1149

Progress

johanvos
johanvos reviewed Jun 4, 2022
View reviewed changes
src/main/resources/native/linux/launcher.c Outdated
@@ -117,5 +117,12 @@ void getLibGLEShandle() {
fprintf(stderr, "NOT IMPLEMENTED\n");
}

#ifdef GVM_17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier done with #ifndef

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I was just following the same pattern as here, in case we ever need to add dummy methods for 17

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@jperedadnr jperedadnr merged commit b8244c5 into gluonhq:master Jun 7, 2022
@jperedadnr jperedadnr deleted the 1149-dummyembedded branch June 7, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanvos johanvos johanvos approved these changes

@tiainen tiainen Awaiting requested review from tiainen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dummy method needed for Linux-AArch64/JDK11
2 participants
@jperedadnr @johanvos