Make ie4uinit.exe execution optional #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperedadnr
reviewed
Apr 28, 2024
| @@ -285,6 +285,7 @@ private void createIconResource() throws InterruptedException, IOException { | |||
| // During development if user changes the application icon, the same is not reflected immediately in Explorer. | |||
| // To fix this, a cache clearance of the Windows explorer is required. | |||
| private void clearExplorerCache() throws IOException, InterruptedException { | |||
| if (!executableOnPath("ie4uinit.exe")) return; | |||
There was a problem hiding this comment.
Add a log if this happens, warning the user that the application icon might have been cached and not updated properly?
use 'where' to check if an executable is on the PATH
kkriske
force-pushed
the
make-ie4uinit-optional
branch
from
0cc2629
to
44f0cf4
Compare
jperedadnr
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Build on WindowsServerCore containers fail because
ie4uinitdoes not exist.Fixes #1239
Progress