Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception after deleting reviewer's current note #87

Closed
zjosua opened this issue Dec 4, 2018 · 2 comments · Fixed by #88
Closed

Exception after deleting reviewer's current note #87

zjosua opened this issue Dec 4, 2018 · 2 comments · Fixed by #88

Comments

@zjosua
Copy link
Contributor

zjosua commented Dec 4, 2018

Prerequisite checklist

  • [ x ] In case of a bug: Have you tried restarting Anki?
  • [ x ] Are you running the latest version of the add-on. Have you redownloaded the add-on from AnkiWeb to make sure?
  • [ x ] Did you check the add-on documentation (e.g. AnkiWeb description, Wiki if it exists) for known issues?
  • [ x ] Did you perform a cursory search through the existing issue reports?

What is the problem/feature you would like to see fixed/implemented?

After deleting the note that was shown in the reviewer, the add-on causes an exception as it tries to reload the deleted note.

How can we reproduce the problem?

  1. get the reviewer to display an IO note
  2. click Edit
  3. invoke Image Occlusion Enhanced - Edit Mode
  4. delete the mask for the card that is shown in the previewer
  5. click Edit Cards
  6. confirm

Expected behavior: Reviewer loads another note.

Actual behavior:

Caught exception:
  File "/home/zjosua/.local/share/Anki2/addons21/1374772155/add.py", line 340, in onToHtmlCallback
    self.ed.web.reload()
<class 'AttributeError'>: 'NoneType' object has no attribute 'reload'

Reproducible?: yes

Version information

Anki

Version 2.1.6-beta2
Qt 5.11.2 PyQt 5.11.3

System

  • Operating system: Debian
  • Version: stretch
@AdrienLemaire
Copy link

@glutanimate I just faced the same issue. When can we expect an update for the plugin? (I'm hoping that I can click "Check for updates" from the anki add-ons page, and get done with it :) )

@glutanimate
Copy link
Owner

@Fandekasp I recently pushed out a new alpha release on GitHub. It's in the new .ankiaddon format, so you can simply drag and drop it onto the add-on window on reasonably recent Anki releases.

As for publishing the release to AnkiWeb, I'm currently reworking my build chain for most of my add-ons (e.g. with anki-addon-builder), as it's become increasingly difficult to maintain 50+ add-ons at once. Unfortunately this means that everything thing else had to take somewhat of a backseat for a bit.

However, once all of this behind-the-scenes work is done, I should be able to push out releases much more quickly in the future.

Noxgrim pushed a commit to Noxgrim/image-occlusion-enhanced that referenced this issue Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants