Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor component signatures #104

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Refactor component signatures #104

merged 6 commits into from
Dec 27, 2023

Conversation

gmac
Copy link
Owner

@gmac gmac commented Dec 25, 2023

⚠️ Minor breaking change

This gives a supergraph reference to Request, and then refactors Planner, Executor, and Shaper to simply wrap a request.

This shift makes requests act as the central hub of operations, similar to Query in GraphQL Ruby. This sets requests up to handle more contextual concerns such as visibility and authorization.

Migration steps

  1. See doc changes in PR.
  2. Request now takes a supergraph instance as its first required argument.
  3. Planner, Executor, and Shaper now simply take a request argument. Better yet, don't use these components directly and invoke their behaviors through the request.

@gmac gmac force-pushed the gmac/refactor_component_sigs branch from d46525e to 543acd8 Compare December 26, 2023 19:57
@gmac gmac force-pushed the gmac/refactor_component_sigs branch from 512fb06 to 1a8952e Compare December 27, 2023 01:44
This was referenced Dec 27, 2023
@gmac gmac changed the base branch from main to v1_2_0 December 27, 2023 02:39
@gmac gmac merged commit 214733f into v1_2_0 Dec 27, 2023
4 checks passed
@gmac gmac deleted the gmac/refactor_component_sigs branch December 27, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant