Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Executable call args #112

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Reorder Executable call args #112

merged 1 commit into from
Dec 29, 2023

Conversation

gmac
Copy link
Owner

@gmac gmac commented Dec 29, 2023

⚠️ Minor breaking change

This reorders and reduces Executable.call arguments. The method signature is now:

Executable.call(request, document, variables)

Changes to note:

  • request is now the first argument.
  • former context argument has been removed in favor of request.context.
  • former location argument has been removed without replacement, as executables should have implicit awareness of their assigned target.

@gmac gmac merged commit e069f95 into v1_2_0 Dec 29, 2023
@gmac gmac deleted the reorder_executable_args branch December 29, 2023 04:42
@gmac gmac mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant