Fix output buffer is imcomplete working in child_process (sass#1834)

Fix premature exit before the output stream is fully flushed
gmaliar · Dec 17, 2016 · ec5aabc · ec5aabc
1 parent 7e32a94
commit ec5aabc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/bin/node-sass b/bin/node-sass
@@ -10,6 +10,7 @@ var Emitter = require('events').EventEmitter,
   glob = require('glob'),
   sass = require('../lib'),
   render = require('../lib/render'),
+  stdout = require('stdout-stream'),
   stdin = require('get-stdin'),
   fs = require('fs');
 
@@ -160,15 +161,7 @@ function getEmitter() {
     }
   });
 
-  emitter.on('log', function(data) {
-    console.log(data);
-  });
-
-  emitter.on('done', function() {
-    if (!options.watch && !options.directory) {
-      process.exit();
-    }
-  });
+  emitter.on('log', stdout.write.bind(stdout));
 
   return emitter;
 }

diff --git a/package.json b/package.json
@@ -69,7 +69,8 @@
     "node-gyp": "^3.3.1",
     "npmlog": "^4.0.0",
     "request": "^2.61.0",
-    "sass-graph": "^2.1.1"
+    "sass-graph": "^2.1.1",
+    "stdout-stream": "^1.4.0"
   },
   "devDependencies": {
     "coveralls": "^2.11.8",