Feat dsi #141
Merged
Feat dsi #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there are a few things to talk about later, but I'm good merging this in. great work @rhugman dialing this up! Def a great addition |
mnfienen
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
I made a bunch of changes - up to you guys @rhugman and @jtwhite79 to determine if we ready to merge it in. Great effort getting this going! I learned alot working through it!
|
Checks are failing on linux and mac. This is new... @mnfienen and @jtwhite79 ...do either of you linux/mac users know what is going on? My google-fu is not finding anything relevant. EDIT: looks like this is the cause: https://conda-forge.org/news/2024/07/29/sunsetting-mambaforge/ solved: #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dangerzone: updated pyemu and env.yml for numpy<2.0