Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.7 #182

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Drop support for Python 3.7 #182

merged 2 commits into from
Mar 20, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

Summary/Motivation: IDAES/idaes-pse#1137

Changes proposed in this PR:

  • Remove Python 3.7 from:
    • setup.py
    • GHA workflows
  • Remove unneeded compatibility checks from:
    • Python code
    • Notebooks?

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Mar 17, 2023
@lbianchi-lbl lbianchi-lbl self-assigned this Mar 17, 2023
ksbeattie
ksbeattie approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dangunter
dangunter approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@dangunter dangunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie merged commit e15a69d into gmlc-dispatches:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbeattie ksbeattie ksbeattie approved these changes

@dangunter dangunter dangunter approved these changes

Assignees

@lbianchi-lbl lbianchi-lbl

Labels
Priority:High High Priority Issue or PR
Projects
No open projects
March 2023 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbianchi-lbl @dangunter @ksbeattie