-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DISPATCHES Cleanup #222
base: main
Are you sure you want to change the base?
DISPATCHES Cleanup #222
Conversation
…atches into WIP_fe_models
I believe all the double loop files are "working" now, but As for Otherwise, I think the double loop files are good-to-go. |
...s/fossil_case/ultra_supercritical_plant/storage/double_loop/run_prescient_double_loop_usc.py
Show resolved
Hide resolved
..._studies/fossil_case/ultra_supercritical_plant/storage/double_loop/plugin_double_loop_usc.py
Show resolved
Hide resolved
...studies/fossil_case/ultra_supercritical_plant/storage/double_loop/plot_doubleloop_results.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcusHolly from what I can make out from current error messages, there are 3 python files missing headers, and I dropped comments on three that I saw from a quick skim (there may be others that slipped through cracks but I am assuming these 3 are the only files of concern)
…ispatches into WIP_fe_models
…ispatches into dispatches_cleanup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 77 77
Lines 9307 9307
=======================================
Hits 8361 8361
Misses 946 946 ☔ View full report in Codecov by Sentry. |
This reverts commit 4ea6988.
Some files are duplicated - namely multiperiod_double_loop_usc.py and multiperiod_integrated_storage_usc.py. Both of these files appear inside of and outside of the double_loop folder. I've only updated the files inside the double loop folder, and when I tried to update the files outside of the double loop folder (just copying and pasting the files that I did edit already), the tests fail. Since we don't have the time to fix this now, I'll just make note of it here. I'm also not sure which of the duplicates should stay and which should be deleted because I doubt we actually want these duplicate files. |
Summary/Motivation:
Replacement of #217. Other contributors were unable to push commits into that PR, so we'll continue the effort on this PR.
Description from #217:
This PR adds all work in progress files for the FE case study that addresses the following aspects:
Double loop implementation of FE case study: pending work here includes updating the the nlp design model with the latest in integrated nlp model in the main and get updated prescient data
CCS: pending work here is to update the underlying design models to the latest in the main. Also, to get latest surrogates from the CCSI2 for heat and cost using PCC flue gas. Finally, the models were working around Oct 2022 so they must be made compatible for both latest pyomo and IDAES
Multiperiod GDP: The files must be updated (mainly initialization) for latest multiperiod class (i.e., latest IDAES) and latest Pyomo. needs to improved to obtain reasonable results.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: