Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.4.7 - Improve JsonDecoder._fromJsonMapImpl #40

Merged
merged 4 commits into from
Nov 24, 2024
Merged

v2.4.7 - Improve JsonDecoder._fromJsonMapImpl #40

merged 4 commits into from
Nov 24, 2024

Conversation

gmpassos
Copy link
Owner

No description provided.

@gmpassos
- JsonDecoder:
cee8741 
  - `_fromJsonImpl`: try to parse primitives to `typeInfo` definition (Allow `Map` `String` keys to be parsed as `int`).
@gmpassos
- JsonDecoder:
0afa7ba 
  - `_fromJsonMapImpl`: fix for when `typeInfo` is for a `Map<K,V>`.
@gmpassos
reflection
513aa57
@gmpassos
v2.4.7
d16be44 
- `JsonDecoder`:
  - `_fromJsonImpl`: try to parse primitives to `typeInfo` definition (Allow `Map` `String` keys to be parsed as `int`).
  - `_fromJsonMapImpl`: fix for when `typeInfo` is for a `Map<K,V>`.
@gmpassos gmpassos changed the title Improve json decoder from json map v2.4.7 - Improve JsonDecoder._fromJsonMapImpl Nov 24, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.84%. Comparing base (d8cb6bc) to head (d16be44).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
lib/src/reflection_factory_json.dart 96.42% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   87.22%   86.84%   -0.38%     
==========================================
  Files          13       13              
  Lines        5823     5845      +22     
==========================================
- Hits         5079     5076       -3     
- Misses        744      769      +25
Flag Coverage Δ
unittests 86.84% <96.42%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@gmpassos gmpassos merged commit cb5cc6c into master Nov 24, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gmpassos