Unsafe Masking Changes #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
katherine-hough
commented
Nov 29, 2023
katherine-hough
commented
- Made the IS_JAVA_8 option a runtime only option so the instrumentation of application JARs is not JVM specific
- Reorganized reflection/unsafe masking code
- Refactored the Phosphor patching class visitors
- Removed MethodRecord#getReturnType
- Split ReflectionHidingMV into three MethodVisitors: one for methods where masking is disabled, one for ObjectStreams, and one for everything else
- Refactored ReflectionHidingMV to make it easier to determine which methods are masked
- Added the Mask annotation which is used to indicate that call to an annotated method should be added during instrumentation to replace calls to another method.
- Refactored RuntimeSunMiscUnsafePropagator to pull out common code
- Refactored RuntimeSunMiscUnsafePropagator to use the new Mask annotation
- Renamed RuntimeSunMiscUnsafePropagator to SunUnsafeMasker
* Refactored embedding class and method visitors * Removed method MethodRecord#getReturnType
* Removed Java 8 PhosphorOption since that value should now only be necessary at runtime
* Fixed missing mask from SunUnsafeMasker
…lass * Fixed missing condition from ReflectionHidingMV
…eJDKInternalUnsafePropagator * Renamed edu/columbia/cs/psl/phosphor/runtime/RuntimeJDKInternalUnsafePropagator to JdkUnsafeMasker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.