Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #12 #13

Merged
merged 1 commit into from
Sep 21, 2020
Merged

fix: #12 #13

merged 1 commit into from
Sep 21, 2020

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Sep 21, 2020

What does this implement/fix? Explain your changes.

fix: #12

Does this close any currently open issues?

Yes

@gnebbia gnebbia merged commit a3e04fc into gnebbia:master Sep 21, 2020
@gnebbia
Copy link
Owner

gnebbia commented Sep 21, 2020

Ok thanks a lot! I merged your PR, and also converted all paths to string in the config.py module.

@yihong0618
Copy link
Contributor Author

yihong0618 commented Sep 21, 2020

Ok thanks a lot! I merged your PR, and also converted all paths to string in the config.py module.

@gnebbia please don't

I have tested.

If you str dir file.
when you kb erase then will cause the str can not mkdir problem.
You can test.

@gnebbia
Copy link
Owner

gnebbia commented Sep 21, 2020

Sorry what should I test? in kb erase, no directory is created with mkdir... can you be more specific ?

@yihong0618
Copy link
Contributor Author

@gnebbia
If you covert all to str, you will find this problem

image

@yihong0618
Copy link
Contributor Author

image

Maybe only covert these two red square?

@gnebbia
Copy link
Owner

gnebbia commented Sep 21, 2020

Ok thanks a lot for your help! I think the last commit solved everything, by converting the str back to path when directory creation is required.
Can you confirm that?
Please do a pip uninstall kb and then a pip install . # there is a dot
within the kb directory after having pulled the last commits.

@yihong0618
Copy link
Contributor Author

yihong0618 commented Sep 21, 2020

@gnebbia Cool, I think it works perfectly.

P.S.
Thank you for your wonderful repo, that's what I am looking for quite a long time.

@gnebbia
Copy link
Owner

gnebbia commented Sep 21, 2020

Well thanks to you @yihong0618 ! If you didn't warn me about this, I never would have found the bug!

Thanks for your support and appreciation!
P.S.: Feel free to fork the project or implement new features as pull requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python3.6 not work
2 participants