-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #12 #13
fix: #12 #13
Conversation
Ok thanks a lot! I merged your PR, and also converted all paths to string in the config.py module. |
@gnebbia please don't I have tested. If you str dir file. |
Sorry what should I test? in kb erase, no directory is created with mkdir... can you be more specific ? |
@gnebbia |
Ok thanks a lot for your help! I think the last commit solved everything, by converting the str back to path when directory creation is required. |
@gnebbia Cool, I think it works perfectly. P.S. |
Well thanks to you @yihong0618 ! If you didn't warn me about this, I never would have found the bug! Thanks for your support and appreciation! |
What does this implement/fix? Explain your changes.
fix: #12
Does this close any currently open issues?
Yes