Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize header parsing #15

Closed
wants to merge 5 commits into from
Closed

Generalize header parsing #15

wants to merge 5 commits into from

Commits on Feb 15, 2020

  1. Allow header parsing to fail 

    Let ParseableHeader return errors if parsing fails so that more interesting header parsers can be written and parsing can fail early if headers are not as expected. Also make CsvRow a case class to allow for pattern matching
    @ybasket
    ybasket authored and Yannick Heiber committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    48e4087 View commit details
    Browse the repository at this point in the history

  2. Allow csv headers to not be a NEL

    Yannick Heiber committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    31bfe4f View commit details
    Browse the repository at this point in the history

  3. Refactor CsvRow to allow non-NEL headers 

    Refactor NEL-based methods to be extension methods available when the header is actually a NEL. Add some syntactic sugar to hide the details and provide the old NEL comfort, keeping some source compatibility.
    Yannick Heiber committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    0fcbd9b View commit details
    Browse the repository at this point in the history

  4. Adjust Readme 

    Add ParseableNelHeader type alias for better readability
    Yannick Heiber committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    9ff2fb7 View commit details
    Browse the repository at this point in the history

  5. Fix generic derivation

    Yannick Heiber committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    7855376 View commit details
    Browse the repository at this point in the history