Improve handling of headers #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satabin
reviewed
Feb 27, 2020
satabin
reviewed
Feb 29, 2020
| Header(firstRow) match { | ||
| case Left(error) => Pull.raiseError[F](error) | ||
| case Right(headers) if headers.length =!= firstRow.length => | ||
| Pull.raiseError[F](new HeaderError("The count of headers must match the count of columns")) |
There was a problem hiding this comment.
Potentially add the sizes in the message, I think it can be useful when this happens, to debug
satabin
reviewed
Feb 29, 2020
csv/src/fs2/data/csv/package.scala
Outdated
| def attemptDecode[F[_], R](implicit F: Applicative[F], | ||
| R: RowDecoder[R]): Pipe[F, NonEmptyList[String], DecoderResult[R]] = | ||
| _.map(R(_)) | ||
| /** Transforms a stream of raw CSV rows into rows, skipping the first line to ignore the headers. */ |
There was a problem hiding this comment.
First "line" is confusing in the context of CSV, I prefer to use "row", as it might span several lines.
|
2 minor comments, otherwise LGTM. |
Both addressed in afe6c82 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #15, see discussion there for motivating use cases.
Includes:
ParseableHeaderto parse all header columns at once to allow for more elaborated validationRowclass to represent csv rows without headers properlyCsvRowacase classextendingRowand make headers non-optionalskipHeadersandwithHeaderspipes to cover all combinations of headers being present in the file and in the desired output