Add more JSON utilities #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This operation is the counterpart of `values`
ybasket
requested changes
May 22, 2020
satabin
force-pushed
the
json/more-utilities
branch
from
3f0bca9
to
f93e0ea
Compare
satabin
commented
May 23, 2020
|
|
||
| private def jsonString(s: String, key: Boolean): Unit = { | ||
| @tailrec | ||
| def loop(idx: Int): Unit = |
There was a problem hiding this comment.
@ybasket I also fixed escaping, but for the sake of "you never know what you do on a Saturday morning, so better safe than sorry", can you quickly check this new version?
There was a problem hiding this comment.
It's also Saturday morning for me ;)
But looks all reasonable!
satabin
force-pushed
the
json/more-utilities
branch
2 times, most recently
from
18ca2ee
to
6fa023c
Compare
ybasket
approved these changes
May 23, 2020
|
|
||
| private def jsonString(s: String, key: Boolean): Unit = { | ||
| @tailrec | ||
| def loop(idx: Int): Unit = |
There was a problem hiding this comment.
It's also Saturday morning for me ;)
But looks all reasonable!
It comes in two flavors: - pipes emitting rendered string chunks - collectors accumulating all rendered values in one string.
satabin
force-pushed
the
json/more-utilities
branch
from
6fa023c
to
c452601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the full roundtrip, this adds: