-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more JSON utilities #27
Conversation
This operation is the counterpart of `values`
3f0bca9
to
f93e0ea
Compare
|
||
private def jsonString(s: String, key: Boolean): Unit = { | ||
@tailrec | ||
def loop(idx: Int): Unit = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ybasket I also fixed escaping, but for the sake of "you never know what you do on a Saturday morning, so better safe than sorry", can you quickly check this new version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also Saturday morning for me ;)
But looks all reasonable!
18ca2ee
to
6fa023c
Compare
|
||
private def jsonString(s: String, key: Boolean): Unit = { | ||
@tailrec | ||
def loop(idx: Int): Unit = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also Saturday morning for me ;)
But looks all reasonable!
It comes in two flavors: - pipes emitting rendered string chunks - collectors accumulating all rendered values in one string.
6fa023c
to
c452601
Compare
In order to make the full roundtrip, this adds: