Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoders for CSV #29

Merged
merged 9 commits into from
Jun 9, 2020
Merged

Encoders for CSV #29

merged 9 commits into from
Jun 9, 2020

Conversation

ybasket
Copy link
Collaborator

@ybasket ybasket commented May 26, 2020

No description provided.

@ybasket ybasket force-pushed the csv-encoder branch 2 times, most recently from 90249ea to 0ed7dc8 Compare June 5, 2020 14:57
@satabin satabin added this to the 0.7.0 milestone Jun 6, 2020
@ybasket ybasket changed the title WIP: Encoders for CSV Encoders for CSV Jun 8, 2020
@ybasket ybasket marked this pull request as ready for review June 8, 2020 12:29
@ybasket ybasket requested a review from satabin June 8, 2020 12:29
Copy link
Member

@satabin satabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments also, otherwise LGTM.

csv/src/fs2/data/csv/CellEncoder.scala Outdated Show resolved Hide resolved
csv/src/fs2/data/csv/package.scala Outdated Show resolved Hide resolved
csv/src/fs2/data/csv/package.scala Outdated Show resolved Hide resolved
Copy link
Member

@satabin satabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, let's merge this.

@satabin satabin merged commit a62fc6c into gnieh:master Jun 9, 2020
@satabin satabin added enhancement New feature or request csv labels Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csv enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants