Decode bignums properly #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for bignum decoding to match the encoding logic for high-level integer values and hence enable roundtrip for them. Closes #452
ybasket
commented
Feb 26, 2023
satabin
reviewed
Feb 28, 2023
cbor/shared/src/main/scala/fs2/data/cbor/high/internal/ValueParser.scala
Outdated
Show resolved
Hide resolved
satabin
reviewed
Feb 28, 2023
cbor/shared/src/main/scala/fs2/data/cbor/high/internal/ValueParser.scala
Show resolved
Hide resolved
Float.floatToIntBits and Double.doubleToLongBits started making trouble linking on JS after an unrelated change.
satabin
approved these changes
Mar 22, 2023
satabin
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for bignum decoding to match the encoding logic for high-level integer values and hence enable roundtrip for them.
Closes #452