Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Json transformation pipes #49

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Conversation

satabin
Copy link
Member

@satabin satabin commented Jul 28, 2020

One of them allows for filtering values out of the stream, which
includes to be cautious to be sure the emitted stream is still valid. We
have to make sure that the key was not emitted if the value is going to
be dropped. This introduces a way to delay the emission of a key until
we know for sure the value is kept.

Fixes #47

@satabin satabin added enhancement New feature or request json labels Jul 28, 2020
@satabin satabin added this to the 0.8.0 milestone Jul 28, 2020
Copy link
Collaborator

@ybasket ybasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM!

json/src/fs2/data/json/package.scala Outdated Show resolved Hide resolved
@satabin
Copy link
Member Author

satabin commented Jul 29, 2020

One minor comment, otherwise LGTM!

I'll had documentation before merging, probably tonight.

One of them allows for filtering values out of the stream, which
includes to be cautious to be sure the emitted stream is still valid. We
have to make sure that the key was not emitted if the value is going to
be dropped. This introduces a way to delay the emission of a key until
we know for sure the value is kept.

Fixes #47
@satabin satabin merged commit b0b2b5c into master Aug 7, 2020
@satabin satabin deleted the json/more-transform branch August 7, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more Json Selector Pipes
2 participants