Fix evaluation of stay moves #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we call `call` when inlining a stay move, we should not step again when evaluating parameters, as it has been done before for this event.
The results should be the same
|
@ybasket when you review it, the actual fix is in this commit. |
ybasket
approved these changes
Sep 26, 2023
finite-state/shared/src/main/scala/fs2/data/mft/query/QueryCompiler.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stay moves appear in MFT (and ESP) RHSs when a state is called on the
Selfforest. This results in the event stream processor to immediately call the state on the currently processed event. This is similar to calling a standard state on the child or next forest, but differs in the way it must evaluate the arguments.In a standard call, the arguments must be stepped to resolve potentially nested (non self) calls. However when resolving a self call we should not apply standard calls, which should only be processed in the next step.
This is fixed in this PR.
Also this PR improves the code by:
Vector[Expr[Out]representation for state parameters instead of aMap[Int, Expr[Out]]