This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Support logback context properties #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hholierhoek
commented
Oct 18, 2021
| if (logbackConfig.hasPath("properties")) { | ||
| if (logbackConfig.getValue("properties") instanceof ConfigObject) { | ||
| final ConfigObject propertyConfigs = (ConfigObject) logbackConfig.getValue("properties"); | ||
| for (Entry<String, ConfigValue> entry : propertyConfigs.toConfig().entrySet()) { |
There was a problem hiding this comment.
The use of propertyConfigs.toConfig().entrySet() here will flatten any objects so one doesn't have to quote a property named 'x.y.z'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a scenario where some configuration (log pattern in my case) is coming from a shared properties file. But each app needs to provide its own app name which is referenced in the pattern.
This PR adds support for configuring properties in the logger context, as one can do with a logback.xml.