New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Update module libvirt setup #1112

Merged

gnif merged 1 commit into gnif:master from netboy3:docsxmldom

Mar 21, 2024

Contributor

netboy3 commented Mar 20, 2024

Restructure the module libvirt XML setup instructions so users understand how to change the XML namespace and that changes need to be atomic.


          [doc] Update module libvirt setup

e40098c

netboy3 requested a review from JJRcop as a code owner

March 20, 2024 18:13

Collaborator

JJRcop commented Mar 20, 2024

Looks good. It would be nice to run sort_words.py --save (run from the doc directory), as it looks like it's slightly unsorted, but not required.

JJRcop approved these changes

View reviewed changes

gnif merged commit e707186 into gnif:master

12 of 16 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet