fix: duplicate titles #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waymobetta
approved these changes
Jan 10, 2024
moul
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
LGTM, but I prefer removing the title from front matter and extracting it from markdown. This will improve the default rendering of markdown files.
Let's merge your current fix, but I'll open an issue to make the opposite move.
Edit: see #56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes duplicate titles.
Duplicate titles appear because
gnoblog-cliextracts the title of the post from the frontmatter and displays it at the top of the page - the fix is to remove the title from all post bodies, and just have it in the frontmatter. below is an example of how the issue looks on test3.