Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match emit/event PR #29

Merged
merged 3 commits into from
May 14, 2024
Merged

fix: match emit/event PR #29

merged 3 commits into from
May 14, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented May 7, 2024

Description

This PR matches the gnolang/gno#2047 PR on the monorepo.

Copy link

netlify bot commented May 7, 2024

Deploy Preview for gno-docs ready!

Name Link
🔨 Latest commit 1354dd0
🔍 Latest deploy log https://app.netlify.com/sites/gno-docs/deploys/66435cb27ad736000846a4f0
😎 Deploy Preview https://deploy-preview-29--gno-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90
Accessibility: 95
Best Practices: 100
SEO: 90
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zivkovicmilos zivkovicmilos marked this pull request as draft May 8, 2024 11:20
@leohhhn leohhhn marked this pull request as ready for review May 13, 2024 14:16
@albttx
Copy link
Member

albttx commented May 14, 2024

@leohhhn I can reproduce this error locally,

10:11:14 AM: [ERROR] Loading of version failed for version current
10:11:14 AM: [ERROR] Unable to build website for locale en.
10:11:14 AM: [ERROR] Error: Invalid sidebar file at "sidebars.js".
10:11:14 AM: These sidebar document ids do not exist:
10:11:14 AM: - concepts/stdlibs/event
10:11:14 AM: - getting-started/local-setup/browsing-gno-source-code

I fixed concepts/stdlibs/event, it was a typo error with eventS. (see b1c762f)

For getting-started/local-setup/browsing-gno-source-code, i don't see anything in the gnolang/gno repo

https://github.com/gnolang/gno/tree/master/docs/getting-started/local-setup

@leohhhn
Copy link
Contributor Author

leohhhn commented May 14, 2024

I fixed concepts/stdlibs/event, it was a typo error with eventS.

Thanks!

For getting-started/local-setup/browsing-gno-source-code, i don't see anything in the gnolang/gno repo

It was removed in the other PR.

@leohhhn leohhhn merged commit 173ab3f into main May 14, 2024
5 checks passed
@leohhhn leohhhn deleted the match/docs-emit branch May 14, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants