Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CODEOWNERS #45

Merged
merged 3 commits into from
Jun 26, 2024
Merged

feat: Add CODEOWNERS #45

merged 3 commits into from
Jun 26, 2024

Conversation

Kouteki
Copy link
Contributor

@Kouteki Kouteki commented Jun 17, 2024

Current state

  • No code owners for docs.gno.land - open PRs aren't automatically assigning reviewers

Desired state

  • Tech staff team are code owners. Open PRs automatically assign reviewers

AC

  • Add @gnolang/tech-staff as docs.gno.land code owners

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for gno-docs canceled.

Name Link
🔨 Latest commit d6d3a69
🔍 Latest deploy log https://app.netlify.com/sites/gno-docs/deploys/667bdae463663600089261a8

@Kouteki Kouteki marked this pull request as ready for review June 17, 2024 12:36
@Kouteki Kouteki self-assigned this Jun 17, 2024
@alexiscolin
Copy link
Member

@Kouteki @leohhhn @zivkovicmilos Do you think we can add me as co-owner for /docusaurus folder? So, I would be pinged for any update that can occur in this folder that I usually maintain.

@leohhhn
Copy link
Contributor

leohhhn commented Jun 25, 2024

Please also add @gnolang/devrels to codeowners

@zivkovicmilos
Copy link
Member

Please also add @gnolang/devrels to codeowners

@leohhhn

We don't believe the DevRel team should be a CODEOWNER for the core team documentation, hence this PR that doesn't include the DevRel team. Core team documentation should stay within the core team, and be managed by the core team, while the DevRel team can advise

@Kouteki
Copy link
Contributor Author

Kouteki commented Jun 26, 2024

@alexiscolin added you as the code owner, and also as the PR reviewer :)

Copy link
Member

@alexiscolin alexiscolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@zivkovicmilos zivkovicmilos merged commit 399d727 into main Jun 26, 2024
6 checks passed
@zivkovicmilos zivkovicmilos deleted the cali-patch1 branch June 26, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants