chore(faucet): compliency gno/faucet and gnoweb

[albttx]

No description provided.

[zivkovicmilos]

Please see my comment about request standardization 🙏

I think we don't need to make this change on the side of this lib, but on gnoweb

[zivkovicmilos]

Nitpick: you can inline this

if err := r.ParseForm(); err != nil {
    http.Error(w, "invalid request body", http.StatusBadRequest)

    return
}

[albttx]

I didn't put it like that to avoid redefine err lower, but i'm fine for adding a var err error :)

[zivkovicmilos]

I do not like the fact we are modelling the behavior of a generic TM2 faucet based on gnoweb (and exact field names in gnoweb. The faucet is envisioned to work through POST requests of a specific format (or we can define our own handlers, endpoints, the faucet lib allows for that).

We are deprecating the old gno faucet anyways, so might as well make the change now.

I propose we take one of these routes:

• modify gnoweb to send a POST with a standard body that is expected in this faucet implementation, this way only 1 thing is changed, and it's on the Gnoweb side (easy route, and longterm the final version, since we are deprecating the old faucet)
• use this faucet as a lib in gno, and extend the faucet to have specific handlers / routes you would use for gnoweb (define custom handlers, like we did for gnochess). This option is less favorable, because it just introduces complexity we'd drop later on when deleting the old faucet

[albttx]

100% ok with this, i just choose a quicker solution for having a fix to work with

[albttx]

but the "form" system is an easier system for the way we're using gno/templating html

[zivkovicmilos]

Closing this in favor of gnolang/gno#1614