remove global var from testing

gnolang · Jun 23, 2023 · 3b9001b · 3b9001b
1 parent 336edab
commit 3b9001b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/examples/gno.land/p/demo/tests/subtests/subtests_test.gno b/examples/gno.land/p/demo/tests/subtests/subtests_test.gno
@@ -0,0 +1,5 @@
+package subtests_test
+
+func TestPrivate(t *testing.T) {
+	println("hello from private test")
+}
diff --git a/gnovm/cmd/gno/test.go b/gnovm/cmd/gno/test.go
@@ -241,11 +241,9 @@ func gnoTestPkg(
 		stdin  = io.In
 		stdout = io.Out
 		stderr = io.Err
+		errs   error
 	)
 
-	filter := splitRegexp(runFlag)
-	var errs error
-
 	mode := tests.ImportModeStdlibsOnly
 	if cfg.withNativeFallback {
 		// XXX: display a warn?
@@ -310,6 +308,7 @@ func gnoTestPkg(
 		for _, testFile := range filetestFiles {
 			testFileName := filepath.Base(testFile)
 			testName := "file/" + testFileName
+			filter := splitRegexp(runFlag)
 			if !shouldRun(filter, testName) {
 				continue
 			}

diff --git a/gnovm/stdlibs/testing/match.gno b/gnovm/stdlibs/testing/match.gno
@@ -166,13 +166,13 @@ func isSpace(r rune) bool {
 	return false
 }
 
-var (
-	matchPat string
-	matchRe  *regexp.Regexp
-)
-
 // based on testing/internal/testdeps.TestDeps.MatchString.
 func matchString(pat, str string) (result bool, err error) {
+	var (
+		matchPat string
+		matchRe  *regexp.Regexp
+	)
+
 	if matchRe == nil || matchPat != pat {
 		matchPat = pat
 		matchRe, err = regexp.Compile(matchPat)