Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chain] Add a get-node-id flag to gnoland secrets // multi-node related #1922

Closed
r3v4s opened this issue Apr 12, 2024 · 0 comments · Fixed by #2361
Closed

[chain] Add a get-node-id flag to gnoland secrets // multi-node related #1922

r3v4s opened this issue Apr 12, 2024 · 0 comments · Fixed by #2361
Assignees
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related

Comments

@r3v4s
Copy link
Contributor

r3v4s commented Apr 12, 2024

Description

This issue is related to 2️⃣ , 3️⃣ of #1836

As comment from above pr to connect another nodes without seeds or pex, we can use persistent-peers to set peers manually which requires form of nodeID@hostname(or ip addr):port.

For Cosmos there are 2 ways to get this value

  1. gaiad tendermint show-node-id
    1.1 CLI level
    1.2 doesn't require actual chain to run
    1.3 requires(calculate or generate node_id from) node_key.json
  1. find id from json rpc :26657/status
    1.1 App(Service) level
    1.2 does require actual chain to run (ofc, to run chain node_key is required too)

Personally, I prefer option 1 since it can be done by single command without requiring any rpc node to connect.

For someone who reads this, FYI I felt we need this feature while testing multi node with some of @zivkovicmilos 's wonderful subcommand PR secrets #1593 config #1605
image

@r3v4s r3v4s added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 12, 2024
@r3v4s r3v4s self-assigned this Apr 12, 2024
@r3v4s r3v4s changed the title [chain] Add a get-node-id flag to gonland secret // multi-node related [chain] Add a get-node-id flag to gnoland secret // multi-node related Apr 12, 2024
@r3v4s r3v4s changed the title [chain] Add a get-node-id flag to gnoland secret // multi-node related [chain] Add a get-node-id flag to gnoland secrets // multi-node related Apr 15, 2024
@Kouteki Kouteki moved this from Triage to Backlog in 🧙‍♂️gno.land core team Apr 19, 2024
@Kouteki Kouteki added this to the 🏗4️⃣ test4.gno.land milestone Apr 19, 2024
@dongwon8247 dongwon8247 moved this to Blocked by / Wishlist / Issues in 🤝🏻 Partner: Onbloc Apr 19, 2024
@dongwon8247 dongwon8247 moved this from Backlog to In Progress in 🤝🏻 Partner: Onbloc May 15, 2024
@r3v4s r3v4s moved this from In Progress to Backlog in 🤝🏻 Partner: Onbloc Jun 5, 2024
@r3v4s r3v4s moved this from Backlog to In Progress in 🤝🏻 Partner: Onbloc Jun 5, 2024
@zivkovicmilos zivkovicmilos assigned zivkovicmilos and unassigned r3v4s Jun 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🤝🏻 Partner: Onbloc Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants