-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for displaying the P2P Address for node secrets info #2361
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2361 +/- ##
=======================================
Coverage 54.63% 54.64%
=======================================
Files 581 581
Lines 77967 77987 +20
=======================================
+ Hits 42598 42614 +16
- Misses 32190 32192 +2
- Partials 3179 3181 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you @zivkovicmilos to bring this in. It certainly improves the bootstrap experience. One small feedback. WOuld it make sense to call the command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think printing protocol (tcp://)
is necessary.
Other than that LGTM 👍
Description
Closes #1922
This PR introduces a new section to the
Node P2P Info
secrets output, that displays the P2P connection address.The secrets fetch command remains unchanged, and this info can be displayed by calling
gnoland secrets get NodeKey
It displays the following values:
These values will be easily fetch-able when we introduce json output support for these outputs in #2301
cc @mazzy89
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description