Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GRC] Refactor GRC20 #2294

Closed
leohhhn opened this issue Jun 6, 2024 · 1 comment · Fixed by #2529
Closed

[GRC] Refactor GRC20 #2294

leohhhn opened this issue Jun 6, 2024 · 1 comment · Fixed by #2529
Assignees
@leohhhn
Labels
🧾 package/realm Tag used for new Realms or Packages.
Milestone
🏗4️⃣ test4.gno.la...

Comments

@leohhhn
Copy link
Contributor

leohhhn commented Jun 6, 2024 •
edited
Loading

Description

This issue concerns refactoring the GRC20 package in the examples folder, just like it was done for GRC721.

Related: https://github.com/gnolang/devrel/issues/87, #1832, #1473
@leohhhn leohhhn self-assigned this Jun 6, 2024
@leohhhn leohhhn added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 6, 2024
@leohhhn leohhhn moved this to Priority 1 in 👥 Team: Devrels Jun 6, 2024
@leohhhn leohhhn moved this from Priority 1 to In Progress in 👥 Team: Devrels Jun 10, 2024
@leohhhn leohhhn mentioned this issue Jun 10, 2024
Closed
7 tasks
@Kouteki Kouteki moved this from Triage to Todo in 🧙‍♂️gno.land core team Jun 14, 2024
@Kouteki Kouteki moved this from Todo to In Progress in 🧙‍♂️gno.land core team Jun 14, 2024
@leohhhn leohhhn moved this from In Progress to In Review in 👥 Team: Devrels Jun 22, 2024
@moul moul mentioned this issue Jul 7, 2024
Merged
@moul
Copy link
Member

moul commented Jul 7, 2024

#2529

@moul moul closed this as completed in #2529 Jul 7, 2024
@moul moul closed this as completed in 3affd95 Jul 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧙‍♂️gno.land core team Jul 7, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in 👥 Team: Devrels Jul 7, 2024
gfanton pushed a commit to gfanton/gno that referenced this issue Jul 23, 2024
@moul @leohhhn @gfanton
feat(examples): refactor grc20 (gnolang#2529)
b0d545a 
Main changes:
- rename `AdminToken` -> `Banker`
- rename `GRC20` -> `Token`
- remove unused helpers
- remove vault (temporarily, will be reimplemented)
- remove the returner ˋerror` when unnecessary
- use `std.Emit`
- use uassert for testing
- better file naming and organization for improved readability

Fixes gnolang#2294
Replaces gnolang#2314 (h/t @leohhhn)
~Depends on gnolang#2534~
BREAKING CHANGE

---------

Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leohhhn leohhhn

Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
👥 Team: Devrels
Status: Done
🧙‍♂️gno.land core team
Archived in project
Milestone
🏗4️⃣ test4.gno.land [POST LAUNCH]
Development

Successfully merging a pull request may close this issue.

feat(examples): refactor grc20 moul/gno
refactor: GRC20 leohhhn/gno
3 participants
@moul @Kouteki @leohhhn