feat: implement gno mod tidy
#1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry-hov
force-pushed
the
hariom/gno-mod-tidy
branch
from
35fad05
to
34f82ef
Compare
harry-hov
force-pushed
the
hariom/gno-mod-tidy
branch
from
34f82ef
to
6507caf
Compare
7 tasks
harry-hov
force-pushed
the
hariom/gno-mod-tidy
branch
from
ece1e87
to
3adcfce
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
+ Coverage 47.84% 47.89% +0.05%
==========================================
Files 369 369
Lines 62764 62836 +72
==========================================
+ Hits 30028 30095 +67
- Misses 30308 30316 +8
+ Partials 2428 2425 -3
☔ View full report in Codecov by Sentry. |
harry-hov
force-pushed
the
hariom/gno-mod-tidy
branch
from
3959fda
to
bbd9c7d
Compare
github-actions
bot
removed
the
🧾 package/realm
moul
reviewed
Oct 11, 2023
moul
reviewed
Oct 11, 2023
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
3 tasks
moul
approved these changes
Oct 12, 2023
thehowl
reviewed
Oct 13, 2023
| } | ||
| for _, imp := range f.Imports { | ||
| importPath := strings.TrimPrefix(strings.TrimSuffix(imp.Path.Value, `"`), `"`) | ||
| if !strings.HasPrefix(importPath, "gno.land/") { |
There was a problem hiding this comment.
Suggested change
| if !strings.HasPrefix(importPath, "gno.land/") { | |
| if !strings.Contains(importPath, ".") { |
I believe this is more future-proof
There was a problem hiding this comment.
Umm. I'm sure there are many place where "gno.land" is hard coded.
I'm okay with both, applying your changes here or to wait till we find a good solution and modify everywhere in a separate PR.
WDYT?
There was a problem hiding this comment.
I think right now we should only have "gno.land/*" import paths, while understanding that with IBC/ICS this will change and will allow for more domains, so that we should still treat all import paths which have a dot (before the first /) to come from external packages.
In any case, whichever is fine here. I've made a note on #1299.
Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Morgan <git@howl.moe>
7 tasks
thehowl
approved these changes
Nov 2, 2023
7 tasks
harry-hov
added a commit
that referenced
this pull request
Nov 6, 2023
CI failing after merging #1035 Seems like some mod files are not tidy.
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
Contains initial implementation of `gno mod tidy` <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com> Co-authored-by: Morgan <git@howl.moe>
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
CI failing after merging gnolang#1035 Seems like some mod files are not tidy.
moul
added a commit
to moul/gno
that referenced
this pull request
Nov 14, 2023
Contains initial implementation of `gno mod tidy` <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com> Co-authored-by: Morgan <git@howl.moe>
moul
pushed a commit
to moul/gno
that referenced
this pull request
Nov 14, 2023
CI failing after merging gnolang#1035 Seems like some mod files are not tidy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains initial implementation of
gno mod tidyContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description