-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce personal realms, add r/manfred/home
#1138
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 55.93% 55.20% -0.74%
==========================================
Files 420 421 +1
Lines 65415 66853 +1438
==========================================
+ Hits 36592 36907 +315
- Misses 25966 27072 +1106
- Partials 2857 2874 +17 ☔ View full report in Codecov by Sentry. |
r/manfred/home
8c9853e
to
7414258
Compare
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
7414258
to
7c35321
Compare
Red CI, see #1139. Edit: fixed. Or not? |
Hello, I've a few questions. Who will be allowed to have personal realms? Will adding new personal realms be permissionless for all GnoLand users, or based on PRs/contributions? If it will be permissionless, do we have any implementation plans for access control on the path level (who can deploy to which paths), as it would be prone to spam? Just trying to understand the concept. I apologize if this is not the right place for this discussion. |
TLDR:
For a more detailed explanation, please check the full discussion on #1107. |
I'm adding this to portal loop #1108 because experimenting with personal things in our realm/namespace will become more common. |
See also: #1224 |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
I made a patch to ensure your test always works, even if we update the examples/ folder. We should focus on making it easier to write and maintain new tests. You can find the patch here: |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
We now have r/manfred/present realm published during the portal loop initiative. This PR’s main goal is now to review the examples/README.md. |
✅ Deploy Preview for gno-docs2 canceled.
|
Signed-off-by: moul <94029+moul@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
examples/README.md
to provide guidelines on the inclusion of personal realms and the continued emphasis on shared content.Embeds #1232
Generated markdown...
Manfred's (gn)home Dashboard
Meme
Status
Online
Personal ToDo List
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description