-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(amino): improve error readability #1179
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1179 +/- ##
=======================================
Coverage 47.79% 47.79%
=======================================
Files 369 369
Lines 62710 62710
=======================================
Hits 29970 29970
Misses 30315 30315
Partials 2425 2425
☔ View full report in Codecov by Sentry. |
Kindly refer to this section on our contributing guidelines. We adopt the conventional commits approach. Here, the term |
7e46c4c
to
8d69521
Compare
@moul Sure, commit have been updated to a |
Thank you, however, for commits it's just a suggestion, the real important location is the PR title; it was more a message for later since you're contributing frequently on the repo :) |
@albttx can we have an after vs before ? |
@gfanton updated, see 🆙 |
b8b30ff
to
09f0aaf
Compare
Following #1178
This fix change the error from being a stack overflow to a simple error message
BEFORE (from #1178 )
AFTER
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description