fix: add support for custom node config file #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkovicmilos
added
🌱 feature
zivkovicmilos
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1240 +/- ##
==========================================
+ Coverage 47.50% 47.85% +0.34%
==========================================
Files 367 372 +5
Lines 62221 62989 +768
==========================================
+ Hits 29561 30142 +581
- Misses 30242 30390 +148
- Partials 2418 2457 +39
☔ View full report in Codecov by Sentry. |
|
While working on this PR I've come to the conclusion that our node init command is a total mess. There is are many side effects happening when specifying the configuration file (inits happening behind the scenes, private key load-in circus...). I patch one thing, and another problem pops up. It's practically impossible to test the I've been discussing with @gfanton internally, and we would like to tackle this problem head on - the node initialization flow needs to be crystal clear and cannot be blocking efforts as it is now
|
7 tasks
ajnavarro
approved these changes
Oct 18, 2023
|
@moul ping for review 🙏 |
moul
reviewed
Oct 19, 2023
moul
reviewed
Oct 19, 2023
moul
reviewed
Oct 19, 2023
moul
approved these changes
Oct 19, 2023
thehowl
pushed a commit
to thehowl/gno
that referenced
this pull request
Oct 21, 2023
## Description This PR adds support for specifying a custom node configuration file using the `--tm2-node-config` flag. Resolves gnolang#1234 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
## Description This PR adds support for specifying a custom node configuration file using the `--tm2-node-config` flag. Resolves gnolang#1234 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for specifying a custom node configuration file using the
--tm2-node-configflag.Resolves #1234
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description