Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add genesis validator subcommand #1259

Merged

Conversation

zivkovicmilos
Copy link
Member

Description

This PR adds support for the genesis validator sub-commands, as outlined in #1228.

Closes #1228

Example genesis validator add command you can use to test out the functionality:

genesis validator add --name milos -pub-key gpub1pgfj7ard9eg82cjtv4u4xetrwqer2dntxyfzxz3pqvknvnspy43c9zp0ts7wgvupldfzkws8kmvvz2eelfmzzupfymwpwzhh9m3 -address g1wpewvuxtyvqqwysndt4f8425tpdg3lf0mhu6fm
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added the 🌱 feature New update to Gno label Oct 19, 2023
@zivkovicmilos zivkovicmilos self-assigned this Oct 19, 2023
@zivkovicmilos zivkovicmilos requested review from jaekwon, moul and a team as code owners October 19, 2023 19:56
@github-actions github-actions bot added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69a1714) 47.27% compared to head (507143d) 47.77%.

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/genesis    #1259      +/-   ##
================================================
+ Coverage         47.27%   47.77%   +0.49%     
================================================
  Files               367      369       +2     
  Lines             61467    62656    +1189     
================================================
+ Hits              29059    29934     +875     
- Misses            30029    30289     +260     
- Partials           2379     2433      +54     
Files Coverage Δ
tm2/pkg/crypto/keys/client/add.go 31.05% <ø> (-0.32%) ⬇️
tm2/pkg/crypto/keys/client/helper.go 50.00% <ø> (-7.15%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zivkovicmilos zivkovicmilos linked an issue Oct 19, 2023 that may be closed by this pull request
@zivkovicmilos zivkovicmilos merged commit 347f3c0 into gnolang:feat/genesis Oct 19, 2023
175 of 176 checks passed
@zivkovicmilos zivkovicmilos deleted the feat/genesis-validator branch October 19, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 🌱 feature New update to Gno
Projects
Status: Done
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

[META] [Genesis] genesis validator
3 participants