Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated io/ioutil methods #1277

Merged
merged 15 commits into from
Nov 8, 2023
Merged

chore: remove deprecated io/ioutil methods #1277

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
17e1598
notJoon:remove-deprecated-io/ioutil
notJoon Oct 21, 2023
92646bb
replace ioutil package in tm2
notJoon Oct 24, 2023
dbb191e
mv codes from ioutil to io
notJoon Oct 24, 2023
48a0d19
fix test
notJoon Oct 24, 2023
ad04163
Merge branch 'master' into remove-depreacate
moul Oct 24, 2023
2bc5f9a
add itoa
notJoon Oct 25, 2023
e8c8801
fmt
notJoon Oct 25, 2023
3fef17d
update io
notJoon Oct 25, 2023
0a5087d
change io0 file name
notJoon Oct 26, 2023
54d5b11
update 558b issue file
notJoon Oct 26, 2023
15c277f
modified to reflect review
notJoon Oct 27, 2023
4435a19
fix io and its tests
notJoon Oct 27, 2023
d6f29c0
remove `ioutil` from gno files and imports.go
notJoon Oct 30, 2023
e83663c
add nopcloser and readall to tests/imports.go
thehowl Nov 7, 2023
33daa49
fix test pkg0
thehowl Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions gnovm/pkg/gnolang/nodes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"fmt"
"go/parser"
"go/token"
"io/ioutil"
"os"
"path/filepath"
"reflect"
Expand Down Expand Up @@ -1095,7 +1094,7 @@

// NOTE: panics if package name is invalid.
func ReadMemPackage(dir string, pkgPath string) *std.MemPackage {
files, err := ioutil.ReadDir(dir)
files, err := os.ReadDir(dir)

Check warning on line 1097 in gnovm/pkg/gnolang/nodes.go

View check run for this annotation

Codecov / codecov/patch

gnovm/pkg/gnolang/nodes.go#L1097 

Added line #L1097 was not covered by tests
if err != nil {
panic(err)
}
Expand Down
3 changes: 1 addition & 2 deletions gnovm/pkg/gnolang/precompile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"go/format"
"go/parser"
"go/token"
"io/ioutil"
"os"
"os/exec"
"path/filepath"
Expand Down Expand Up @@ -112,7 +111,7 @@
func PrecompileAndCheckMempkg(mempkg *std.MemPackage) error {
gofmt := "gofmt"

tmpDir, err := ioutil.TempDir("", mempkg.Name)
tmpDir, err := os.MkdirTemp("", mempkg.Name)

Check warning on line 114 in gnovm/pkg/gnolang/precompile.go

View check run for this annotation

Codecov / codecov/patch

gnovm/pkg/gnolang/precompile.go#L114 

Added line #L114 was not covered by tests
if err != nil {
return err
}
Expand Down
5 changes: 2 additions & 3 deletions gnovm/pkg/gnomod/gnomod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import (
"errors"
"fmt"
"io/ioutil"
"os"
"path/filepath"
"strings"
Expand Down Expand Up @@ -172,9 +171,9 @@
if modPath == "" {
// Check .gno files for package name
// and use it as modPath
files, err := ioutil.ReadDir(rootDir)
files, err := os.ReadDir(rootDir)
if err != nil {
fmt.Errorf("read dir %q: %w", rootDir, err)
return fmt.Errorf("read dir %q: %w", rootDir, err)

Check warning on line 176 in gnovm/pkg/gnomod/gnomod.go

View check run for this annotation

Codecov / codecov/patch

gnovm/pkg/gnomod/gnomod.go#L176 

Added line #L176 was not covered by tests
}

var pkgName gnolang.Name
Expand Down
Loading