Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnomod): test package does not exist #1317

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Oct 29, 2023

Add test for package does not exist.

Not able to reproduce Infinite loop when a requested package does not exist

Closes #835.

cc: @ajnavarro

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (678686a) 55.88% compared to head (85cd159) 55.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
+ Coverage   55.88%   55.90%   +0.02%     
==========================================
  Files         420      420              
  Lines       65373    65373              
==========================================
+ Hits        36531    36546      +15     
+ Misses      25982    25969      -13     
+ Partials     2860     2858       -2     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajnavarro
Copy link
Contributor

LGTM

@harry-hov harry-hov marked this pull request as ready for review November 6, 2023 19:14
@harry-hov harry-hov requested a review from a team as a code owner November 6, 2023 19:14
@harry-hov harry-hov merged commit 041d0a8 into gnolang:master Nov 8, 2023
187 checks passed
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
Add test for package does not exist.

Not able to reproduce `Infinite loop when a requested package does not
exist` (gnolang#835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gnomod: Infinite loop when a requested package does not exist.
3 participants