fix(cmd/gno): allow testing packages which contain test files with package x_test
#1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1330 +/- ##
==========================================
+ Coverage 55.89% 56.12% +0.22%
==========================================
Files 422 422
Lines 65386 65658 +272
==========================================
+ Hits 36548 36849 +301
+ Misses 25976 25937 -39
- Partials 2862 2872 +10 ☔ View full report in Codecov by Sentry. |
albttx
force-pushed
the
albttx/package-already-in-cache
branch
from
f043c79
to
d4316f6
Compare
albttx
force-pushed
the
albttx/package-already-in-cache
branch
from
d4316f6
to
19413b2
Compare
albttx
commented
Nov 6, 2023
albttx
changed the title
albttx
force-pushed
the
albttx/package-already-in-cache
branch
from
19413b2
to
84c9af2
Compare
albttx
changed the title
albttx
force-pushed
the
albttx/package-already-in-cache
branch
from
84c9af2
to
7c0b1cf
Compare
albttx
force-pushed
the
albttx/package-already-in-cache
branch
from
7c0b1cf
to
4758132
Compare
moul
reviewed
Nov 6, 2023
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
moul
reviewed
Nov 6, 2023
moul
reviewed
Nov 6, 2023
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
zivkovicmilos
approved these changes
Nov 7, 2023
ajnavarro
approved these changes
Nov 7, 2023
thehowl
requested changes
Nov 7, 2023
thehowl
changed the title
package x_test
|
@thehowl All good for me :) |
|
@thehowl Could this be moved to last-review / to merge :) |
3 tasks
tbruyelle
reviewed
Nov 16, 2023
|
Agree with @thehowl , a txtar would be appreciated :) |
thehowl
approved these changes
Nov 23, 2023
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
…ackage x_test` (gnolang#1330) Reproduce error from gnolang#638 package ./. already exists in cache EDIT: And fixed it 🎉 ``` $ go run ./gnovm/cmd/gno test --verbose ./examples/gno.land/p/demo/lol panic: package gno.land/p/demo/lol already exists in cache goroutine 1 [running]: github.com/gnolang/gno/gnovm/pkg/gnolang.(*defaultStore).SetCachePackage(0x1400020a240, 0x14005f23e00) /Users/albttx/go/src/github.com/gnolang/gno/gnovm/pkg/gnolang/store.go:207 +0x10c github.com/gnolang/gno/gnovm/pkg/gnolang.(*Machine).RunMemPackage(0x14006aba6c0, 0x1400038ff80, 0x1) /Users/albttx/go/src/github.com/gnolang/gno/gnovm/pkg/gnolang/machine.go:225 +0x190 main.gnoTestPkg({0x16fa42ab0, 0x1e}, {0x1400025f4a0?, 0x1, 0x100a8567c?}, {0x0, 0x0, 0x101374df8?}, 0x1400038e640, 0x14000306820) /Users/albttx/go/src/github.com/gnolang/gno/gnovm/cmd/gno/test.go:354 +0x3f8 main.execTest(0x1400038e640, {0x1400025f3b0, 0x1, 0x1}, 0x0?) /Users/albttx/go/src/github.com/gnolang/gno/gnovm/cmd/gno/test.go:255 +0x804 main.newTestCmd.func1({0x0?, 0x0?}, {0x1400025f3b0?, 0x14000696e58?, 0x0?}) /Users/albttx/go/src/github.com/gnolang/gno/gnovm/cmd/gno/test.go:97 +0x38 github.com/gnolang/gno/tm2/pkg/commands.(*Command).Run(0x0?, {0x100e55608?, 0x14000190010?}) /Users/albttx/go/src/github.com/gnolang/gno/tm2/pkg/commands/command.go:233 +0x17c github.com/gnolang/gno/tm2/pkg/commands.(*Command).Run(0x14000696b00?, {0x100e55608?, 0x14000190010?}) /Users/albttx/go/src/github.com/gnolang/gno/tm2/pkg/commands/command.go:237 +0x12c github.com/gnolang/gno/tm2/pkg/commands.(*Command).ParseAndRun(0x14000180000?, {0x100e55608, 0x14000190010}, {0x140001a6050?, 0x60?, 0x0?}) /Users/albttx/go/src/github.com/gnolang/gno/tm2/pkg/commands/command.go:118 +0x4c main.main() /Users/albttx/go/src/github.com/gnolang/gno/gnovm/cmd/gno/main.go:14 +0x74 exit status 2 ``` <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com> Co-authored-by: Morgan Bazalgette <morgan@morganbaz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce error from #638 package ./. already exists in cache
EDIT: And fixed it 🎉
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description