-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnolang): print nil slices as undefined #1380
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1380 +/- ##
==========================================
+ Coverage 55.98% 56.54% +0.55%
==========================================
Files 420 423 +3
Lines 65443 66448 +1005
==========================================
+ Hits 36640 37570 +930
- Misses 25940 25986 +46
- Partials 2863 2892 +29 ☔ View full report in Codecov by Sentry. |
Awesome. Thanks for addressing my comments. I'll take another look shortly. |
I've been looking at this closely and I think the most correct way to fix this issue may be by following example of how gno/gnovm/pkg/gnolang/values_string.go Lines 246 to 286 in 903ae18
I think What do you think about that approach? |
Yes, that seems reasonable. This approach will ensure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job; looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you 👍
The `println` function was encountering issues when trying to process nil values(e.g. nil slice). This was causing memory errors. The issue has been addressed by adding checks for nil values and handling them appropriately to prevent memory errors. related with: gnolang#1377
The
println
function was encountering issues when trying to process nil values(e.g. nil slice). This was causing memory errors. The issue has been addressed by adding checks for nil values and handling them appropriately to prevent memory errors.related with: #1377