-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement r/demo/postit
#1396
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1396 +/- ##
==========================================
- Coverage 47.98% 47.29% -0.70%
==========================================
Files 372 391 +19
Lines 63091 63067 -24
==========================================
- Hits 30277 29827 -450
- Misses 30352 30761 +409
- Partials 2462 2479 +17 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,188 @@ | |||
package postit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include a comment stating this file is temporary, pending JSON support implementation.
} | ||
|
||
func getUserRefByUsername(username string) *User { | ||
res, ok := users.Get(username) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to be compatible with r/users; or maybe having r/users to be the way to get “verified” while having a built in light alternative?
|
||
func UpdateBio(bio string) string { | ||
// TODO: add checks | ||
caller := std.PrevRealm().Addr() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something i started to work on with a r/profile (#181) realm.
Could worth switching when ready, to have unified bio across the whole contract ecosystem.
@@ -0,0 +1,188 @@ | |||
package postit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding a Render() func too, could just give some basic info and suggest to use the better frontend.
Unlikely to be continued; if someone wants to continue it please open a separate PR continuing Hariom's work. |
Very Basic Twitter Clone
Frontend: https://postitsocial.netlify.app/
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description