fix: upgrade apd lib to version without bug #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deelawn
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1399 +/- ##
==========================================
- Coverage 55.91% 47.23% -8.68%
==========================================
Files 421 375 -46
Lines 65445 62285 -3160
==========================================
- Hits 36595 29422 -7173
- Misses 25992 30457 +4465
+ Partials 2858 2406 -452 ☔ View full report in Codecov by Sentry. |
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
Addresses gnolang#1152 After debugging for a bit it became apparent the sign was being dropped during the operation in the `apd` module. Upgrading to the latest version fixes this. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1152
After debugging for a bit it became apparent the sign was being dropped during the operation in the
apdmodule. Upgrading to the latest version fixes this.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description